fix(card): add wrapper to img #2578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PatternFly-Next preview: https://patternfly-next-pr-2578.surge.sh |
Contributor
|
@christiemolloy I dig it, I think this makes the most sense. Though I wonder if we should be more generic in the element name in case someone wants to put some text or text+icon instead. We could call it |
Member
Author
|
I agree with using a less specific name. Also added class to the docs @mcoker |
mcoker
reviewed
Jan 20, 2020
| <div class="pf-c-card__image{{#if card-image--modifier}} {{card-image--modifier}}{{/if}}" | ||
| {{#if card-image--attribute}} | ||
| {{{card-image--attribute}}} | ||
| <div class="pf-c-card__main{{#if card-main--modifier}} {{card-main--modifier}}{{/if}}" |
Contributor
There was a problem hiding this comment.
can we call it __head-main instead, since it should only exist in __head? I think we should reserve __main in case we want to add that to the root of the card.
Contributor
|
🎉 This PR is included in version 2.50.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2562
There may be a few solutions to this problem, I went with the solution of wrapping the image in its own container, because we don't know how the user will give it height/width. So even if width is added to the image in the html or the svg, it will still size proportionally down. But interested to hear what you guys think @mcoker @mattnolting